Skip to content

Commit

Permalink
mtd: onenand: drop dead code
Browse files Browse the repository at this point in the history
'ret' is always zero, so this is all dead code.

This should quiet Coverity CID #1226739.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
  • Loading branch information
Brian Norris committed Mar 11, 2015
1 parent dc52499 commit 7f2a7ce
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions drivers/mtd/onenand/onenand_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -1743,7 +1743,6 @@ static int onenand_panic_write(struct mtd_info *mtd, loff_t to, size_t len,
struct onenand_chip *this = mtd->priv;
int column, subpage;
int written = 0;
int ret = 0;

if (this->state == FL_PM_SUSPENDED)
return -EBUSY;
Expand Down Expand Up @@ -1786,15 +1785,10 @@ static int onenand_panic_write(struct mtd_info *mtd, loff_t to, size_t len,
onenand_panic_wait(mtd);

/* In partial page write we don't update bufferram */
onenand_update_bufferram(mtd, to, !ret && !subpage);
onenand_update_bufferram(mtd, to, !subpage);
if (ONENAND_IS_2PLANE(this)) {
ONENAND_SET_BUFFERRAM1(this);
onenand_update_bufferram(mtd, to + this->writesize, !ret && !subpage);
}

if (ret) {
printk(KERN_ERR "%s: write failed %d\n", __func__, ret);
break;
onenand_update_bufferram(mtd, to + this->writesize, !subpage);
}

written += thislen;
Expand All @@ -1808,7 +1802,7 @@ static int onenand_panic_write(struct mtd_info *mtd, loff_t to, size_t len,
}

*retlen = written;
return ret;
return 0;
}

/**
Expand Down

0 comments on commit 7f2a7ce

Please sign in to comment.