Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 187239
b: refs/heads/master
c: 440e6ca
h: refs/heads/master
i:
  187237: 1ebc114
  187235: cc2c7d2
  187231: ac9cb14
v: v3
  • Loading branch information
Christoph Hellwig authored and Linus Torvalds committed Mar 12, 2010
1 parent 28fc1f6 commit 7f33cb5
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 63 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: fd341abba65e3d93fc24c132e4c0278d18b6d2fc
refs/heads/master: 440e6ca79aebdc274ce4c625a6f42c8bf3c7bc91
2 changes: 2 additions & 0 deletions trunk/arch/arm/include/asm/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ struct pt_regs {

#ifdef __KERNEL__

#define arch_has_single_step() (1)

#define user_mode(regs) \
(((regs)->ARM_cpsr & 0xf) == 0)

Expand Down
60 changes: 12 additions & 48 deletions trunk/arch/arm/kernel/ptrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -452,12 +452,23 @@ void ptrace_cancel_bpt(struct task_struct *child)
clear_breakpoint(child, &child->thread.debug.bp[i]);
}

void user_disable_single_step(struct task_struct *task)
{
task->ptrace &= ~PT_SINGLESTEP;
ptrace_cancel_bpt(task);
}

void user_enable_single_step(struct task_struct *task)
{
task->ptrace |= PT_SINGLESTEP;
}

/*
* Called by kernel/ptrace.c when detaching..
*/
void ptrace_disable(struct task_struct *child)
{
single_step_disable(child);
user_disable_single_step(child);
}

/*
Expand Down Expand Up @@ -753,53 +764,6 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
ret = ptrace_write_user(child, addr, data);
break;

/*
* continue/restart and stop at next (return from) syscall
*/
case PTRACE_SYSCALL:
case PTRACE_CONT:
ret = -EIO;
if (!valid_signal(data))
break;
if (request == PTRACE_SYSCALL)
set_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
else
clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
child->exit_code = data;
single_step_disable(child);
wake_up_process(child);
ret = 0;
break;

/*
* make the child exit. Best I can do is send it a sigkill.
* perhaps it should be put in the status that it wants to
* exit.
*/
case PTRACE_KILL:
single_step_disable(child);
if (child->exit_state != EXIT_ZOMBIE) {
child->exit_code = SIGKILL;
wake_up_process(child);
}
ret = 0;
break;

/*
* execute single instruction.
*/
case PTRACE_SINGLESTEP:
ret = -EIO;
if (!valid_signal(data))
break;
single_step_enable(child);
clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
child->exit_code = data;
/* give it a chance to run. */
wake_up_process(child);
ret = 0;
break;

case PTRACE_GETREGS:
ret = ptrace_getregs(child, (void __user *)data);
break;
Expand Down
14 changes: 0 additions & 14 deletions trunk/arch/arm/kernel/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,6 @@ extern void ptrace_cancel_bpt(struct task_struct *);
extern void ptrace_set_bpt(struct task_struct *);
extern void ptrace_break(struct task_struct *, struct pt_regs *);

/*
* make sure single-step breakpoint is gone.
*/
static inline void single_step_disable(struct task_struct *task)
{
task->ptrace &= ~PT_SINGLESTEP;
ptrace_cancel_bpt(task);
}

static inline void single_step_enable(struct task_struct *task)
{
task->ptrace |= PT_SINGLESTEP;
}

/*
* Send SIGTRAP if we're single-stepping
*/
Expand Down

0 comments on commit 7f33cb5

Please sign in to comment.