Skip to content

Commit

Permalink
usbtest: make module param pattern writeable
Browse files Browse the repository at this point in the history
Allow module_param to be writeable. This allows us to change
the parameter if usbtest is built-in in the kernel.

Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Vikram Pandita authored and Greg Kroah-Hartman committed Dec 11, 2009
1 parent ed7487c commit 7f4e985
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/usb/misc/usbtest.c
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,9 @@ static struct urb *simple_alloc_urb (
}

static unsigned pattern = 0;
module_param (pattern, uint, S_IRUGO);
MODULE_PARM_DESC(pattern, "i/o pattern (0 == zeroes)");
static unsigned mod_pattern;
module_param_named(pattern, mod_pattern, uint, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(mod_pattern, "i/o pattern (0 == zeroes)");

static inline void simple_fill_buf (struct urb *urb)
{
Expand Down Expand Up @@ -1567,6 +1568,8 @@ usbtest_ioctl (struct usb_interface *intf, unsigned int code, void *buf)

// FIXME USBDEVFS_CONNECTINFO doesn't say how fast the device is.

pattern = mod_pattern;

if (code != USBTEST_REQUEST)
return -EOPNOTSUPP;

Expand Down

0 comments on commit 7f4e985

Please sign in to comment.