Skip to content

Commit

Permalink
Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
Browse files Browse the repository at this point in the history
* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6:
  USB: Close usb_find_interface race v3
  Revert "USB: Close usb_find_interface race"
  • Loading branch information
Linus Torvalds committed Dec 15, 2009
2 parents e956e6b + c2d284e commit 7f6cd54
Showing 1 changed file with 16 additions and 7 deletions.
23 changes: 16 additions & 7 deletions drivers/usb/core/usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,18 +167,23 @@ struct usb_host_interface *usb_altnum_to_altsetting(
}
EXPORT_SYMBOL_GPL(usb_altnum_to_altsetting);

struct find_interface_arg {
int minor;
struct device_driver *drv;
};

static int __find_interface(struct device *dev, void *data)
{
int *minor = data;
struct find_interface_arg *arg = data;
struct usb_interface *intf;

if (!is_usb_interface(dev))
return 0;

if (dev->driver != arg->drv)
return 0;
intf = to_usb_interface(dev);
if (intf->minor != -1 && intf->minor == *minor)
return 1;
return 0;
return intf->minor == arg->minor;
}

/**
Expand All @@ -187,14 +192,18 @@ static int __find_interface(struct device *dev, void *data)
* @minor: the minor number of the desired device
*
* This walks the bus device list and returns a pointer to the interface
* with the matching minor. Note, this only works for devices that share the
* USB major number.
* with the matching minor and driver. Note, this only works for devices
* that share the USB major number.
*/
struct usb_interface *usb_find_interface(struct usb_driver *drv, int minor)
{
struct find_interface_arg argb;
struct device *dev;

dev = bus_find_device(&usb_bus_type, NULL, &minor, __find_interface);
argb.minor = minor;
argb.drv = &drv->drvwrap.driver;

dev = bus_find_device(&usb_bus_type, NULL, &argb, __find_interface);

/* Drop reference count from bus_find_device */
put_device(dev);
Expand Down

0 comments on commit 7f6cd54

Please sign in to comment.