Skip to content

Commit

Permalink
usb: convert USB_QUIRK_RESET_MORPHS to USB_QUIRK_RESET
Browse files Browse the repository at this point in the history
Since the attribute avoid_reset_quirk is work for all devices including
those devices that can't morph, convert USB_QUIRK_RESET_MORPHS to
USB_QUIRK_RESET.

Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Lan Tianyu authored and Greg Kroah-Hartman committed Aug 20, 2012
1 parent 2d36684 commit 7fda953
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion drivers/usb/core/quirks.c
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ void usb_detect_quirks(struct usb_device *udev)
* for all devices. It will affect things like hub resets
* and EMF-related port disables.
*/
if (!(udev->quirks & USB_QUIRK_RESET_MORPHS))
if (!(udev->quirks & USB_QUIRK_RESET))
udev->persist_enabled = 1;
#endif /* CONFIG_PM */
}
Expand Down
6 changes: 3 additions & 3 deletions drivers/usb/core/sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ show_avoid_reset_quirk(struct device *dev, struct device_attribute *attr, char *
struct usb_device *udev;

udev = to_usb_device(dev);
return sprintf(buf, "%d\n", !!(udev->quirks & USB_QUIRK_RESET_MORPHS));
return sprintf(buf, "%d\n", !!(udev->quirks & USB_QUIRK_RESET));
}

static ssize_t
Expand All @@ -210,9 +210,9 @@ set_avoid_reset_quirk(struct device *dev, struct device_attribute *attr,
return -EINVAL;
usb_lock_device(udev);
if (val)
udev->quirks |= USB_QUIRK_RESET_MORPHS;
udev->quirks |= USB_QUIRK_RESET;
else
udev->quirks &= ~USB_QUIRK_RESET_MORPHS;
udev->quirks &= ~USB_QUIRK_RESET;
usb_unlock_device(udev);
return count;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/usb/storage/transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -1331,7 +1331,7 @@ int usb_stor_port_reset(struct us_data *us)
int result;

/*for these devices we must use the class specific method */
if (us->pusb_dev->quirks & USB_QUIRK_RESET_MORPHS)
if (us->pusb_dev->quirks & USB_QUIRK_RESET)
return -EPERM;

result = usb_lock_device_for_reset(us->pusb_dev, us->pusb_intf);
Expand Down
4 changes: 2 additions & 2 deletions include/linux/usb/quirks.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
/* device can't handle its Configuration or Interface strings */
#define USB_QUIRK_CONFIG_INTF_STRINGS 0x00000008

/*device will morph if reset, don't use reset for handling errors */
#define USB_QUIRK_RESET_MORPHS 0x00000010
/* device can't be reset(e.g morph devices), don't use reset */
#define USB_QUIRK_RESET 0x00000010

/* device has more interface descriptions than the bNumInterfaces count,
and can't handle talking to these interfaces */
Expand Down

0 comments on commit 7fda953

Please sign in to comment.