Skip to content

Commit

Permalink
Bluetooth: Stop ack_timer if ERTM enters in Local Busy or SREJ_SENT
Browse files Browse the repository at this point in the history
The ack_timer is implemation specific, disabling it in such situation
avoids some potencial errors in the ERTM protocol.

Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Reviewed-by: João Paulo Rechi Vita <jprvita@profusion.mobi>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Gustavo F. Padovan authored and Marcel Holtmann committed Jul 21, 2010
1 parent f8df39f commit 7fe9b29
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions net/bluetooth/l2cap.c
Original file line number Diff line number Diff line change
Expand Up @@ -3665,6 +3665,8 @@ static int l2cap_push_rx_skb(struct sock *sk, struct sk_buff *skb, u16 control)

pi->conn_state |= L2CAP_CONN_RNR_SENT;

del_timer(&pi->ack_timer);

queue_work(_busy_wq, &pi->busy_work);

return err;
Expand Down Expand Up @@ -3914,6 +3916,8 @@ static inline int l2cap_data_channel_iframe(struct sock *sk, u16 rx_control, str
pi->conn_state |= L2CAP_CONN_SEND_PBIT;

l2cap_send_srejframe(sk, tx_seq);

del_timer(&pi->ack_timer);
}
return 0;

Expand Down

0 comments on commit 7fe9b29

Please sign in to comment.