---

yaml --- r: 29691 b: refs/heads/master c: 0928d68 h: refs/heads/master i: 29689: 7f66410 29687: fb0d8d2 v: v3
git-mirror · Jun 25, 2006 · 7fec03a · 7fec03a
1 parent 3f9402f
commit 7fec03a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 2e6113908fe76a06295cb243f1f2f0eea055b0c2
+refs/heads/master: 0928d68056fa25456830b1de9f0ee89bc37447cd
diff --git a/trunk/fs/openpromfs/inode.c b/trunk/fs/openpromfs/inode.c
@@ -448,10 +448,11 @@ static ssize_t property_write(struct file *filp, const char __user *buf,
 					*q |= simple_strtoul (tmp, NULL, 16);
 					buf += last_cnt;
 				} else {
-					char tchars[17]; /* XXX yuck... */
+					char tchars[2 * sizeof(long) + 1];
 
-					if (copy_from_user(tchars, buf, 16))
+					if (copy_from_user(tchars, buf, sizeof(tchars) - 1))
 						return -EFAULT;
+                                        tchars[sizeof(tchars) - 1] = '\0';
 					*q = simple_strtoul (tchars, NULL, 16);
 					buf += 9;
 				}