Skip to content

Commit

Permalink
ipv6: Remove optimistic DAD flag test in ipv6_add_addr()
Browse files Browse the repository at this point in the history
The route we have here is for the address being added to the interface,
ie. for input packet processing.

Therefore using that route to determine whether an output nexthop gateway
is known and resolved doesn't make any sense.

So, simply remove this test, it never triggered anyways.

Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-By: Neil Horman <nhorman@tuxdriver.com>
  • Loading branch information
David Miller committed Dec 28, 2011
1 parent d79aec8 commit 7ffbcec
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions net/ipv6/addrconf.c
Original file line number Diff line number Diff line change
Expand Up @@ -650,16 +650,6 @@ ipv6_add_addr(struct inet6_dev *idev, const struct in6_addr *addr, int pfxlen,

ifa->rt = rt;

/*
* part one of RFC 4429, section 3.3
* We should not configure an address as
* optimistic if we do not yet know the link
* layer address of our nexhop router
*/

if (dst_get_neighbour_noref_raw(&rt->dst) == NULL)
ifa->flags &= ~IFA_F_OPTIMISTIC;

ifa->idev = idev;
in6_dev_hold(idev);
/* For caller */
Expand Down

0 comments on commit 7ffbcec

Please sign in to comment.