Skip to content

Commit

Permalink
perf tools: Drop asm/types.h wrapper
Browse files Browse the repository at this point in the history
Wrapping the kernel headers is dangerous when it comes to arch
headers. Once we wrap asm/types.h, it will also replace the
glibc asm/types.h, not only the kernel one.

This results in build errors on some machines.

Drop this wrapper and do its work from linux/types.h wrapper,
also the glibc asm/types.h can already handle most of the type
definition it was doing (typedef __u64, __u32, etc...).

Todo: Check the others asm/*.h wrappers to prevent from other
conflicts.

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Anton Blanchard <anton@samba.org>
LKML-Reference: <1256246604-17156-3-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Frederic Weisbecker authored and Ingo Molnar committed Oct 23, 2009
1 parent a4fb581 commit 802da5f
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 19 deletions.
1 change: 0 additions & 1 deletion tools/perf/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,6 @@ LIB_H += util/include/asm/bitops.h
LIB_H += util/include/asm/byteorder.h
LIB_H += util/include/asm/swab.h
LIB_H += util/include/asm/system.h
LIB_H += util/include/asm/types.h
LIB_H += util/include/asm/uaccess.h
LIB_H += perf.h
LIB_H += util/event.h
Expand Down
12 changes: 12 additions & 0 deletions tools/perf/util/include/asm/bitops.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
#ifndef _PERF_ASM_BITOPS_H_
#define _PERF_ASM_BITOPS_H_

#include <sys/types.h>
#include "../../types.h"
#include <linux/compiler.h>

/* CHECKME: Not sure both always match */
#define BITS_PER_LONG __WORDSIZE

#include "../../../../include/asm-generic/bitops/__fls.h"
#include "../../../../include/asm-generic/bitops/fls.h"
#include "../../../../include/asm-generic/bitops/fls64.h"
#include "../../../../include/asm-generic/bitops/__ffs.h"
#include "../../../../include/asm-generic/bitops/ffz.h"
#include "../../../../include/asm-generic/bitops/hweight.h"

#endif
2 changes: 1 addition & 1 deletion tools/perf/util/include/asm/byteorder.h
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#include "../asm/types.h"
#include <asm/types.h>
#include "../../../../include/linux/swab.h"
17 changes: 0 additions & 17 deletions tools/perf/util/include/asm/types.h

This file was deleted.

2 changes: 2 additions & 0 deletions tools/perf/util/include/linux/types.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#ifndef _PERF_LINUX_TYPES_H_
#define _PERF_LINUX_TYPES_H_

#include <asm/types.h>

#define DECLARE_BITMAP(name,bits) \
unsigned long name[BITS_TO_LONGS(bits)]

Expand Down

0 comments on commit 802da5f

Please sign in to comment.