Skip to content

Commit

Permalink
ceph: remove bogus invalidate_mapping_pages
Browse files Browse the repository at this point in the history
We were invalidating mapping pages when dropping FILE_CACHE in
__send_cap().  But ceph_check_caps attempts to invalidate already, and
also checks for success, so we should never get to this point.

Signed-off-by: Sage Weil <sage@newdream.net>
  • Loading branch information
Sage Weil committed Feb 11, 2010
1 parent 0840d8a commit 8031049
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions fs/ceph/caps.c
Original file line number Diff line number Diff line change
Expand Up @@ -1137,12 +1137,6 @@ static int __send_cap(struct ceph_mds_client *mdsc, struct ceph_cap *cap,

spin_unlock(&inode->i_lock);

if (dropping & CEPH_CAP_FILE_CACHE) {
/* invalidate what we can */
dout("invalidating pages on %p\n", inode);
invalidate_mapping_pages(&inode->i_data, 0, -1);
}

ret = send_cap_msg(session, ceph_vino(inode).ino, cap_id,
op, keep, want, flushing, seq, flush_tid, issue_seq, mseq,
size, max_size, &mtime, &atime, time_warp_seq,
Expand Down

0 comments on commit 8031049

Please sign in to comment.