Skip to content

Commit

Permalink
net: be2net: remove unnecessary pci_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jingoo Han authored and David S. Miller committed Oct 21, 2013
1 parent 5f258a1 commit 806636f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/ethernet/emulex/benet/be_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -4204,7 +4204,6 @@ static void be_remove(struct pci_dev *pdev)

pci_disable_pcie_error_reporting(pdev);

pci_set_drvdata(pdev, NULL);
pci_release_regions(pdev);
pci_disable_device(pdev);

Expand Down Expand Up @@ -4534,7 +4533,6 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
be_ctrl_cleanup(adapter);
free_netdev:
free_netdev(netdev);
pci_set_drvdata(pdev, NULL);
rel_reg:
pci_release_regions(pdev);
disable_dev:
Expand Down

0 comments on commit 806636f

Please sign in to comment.