Skip to content

Commit

Permalink
RDS: return to a single-threaded krdsd
Browse files Browse the repository at this point in the history
We were seeing very nasty bugs due to fundamental assumption the current code
makes about concurrent work struct processing.  The code simpy isn't able to
handle concurrent connection shutdown work function execution today, for
example, which is very much possible once a multi-threaded krdsd was
introduced.  The problem compounds as additional work structs are added to the
mix.

krdsd is no longer perforance critical now that send and receive posting and
FMR flushing are done elsewhere, so the safest fix is to move back to the
single threaded krdsd that the current code was built around.

Signed-off-by: Zach Brown <zach.brown@oracle.com>
  • Loading branch information
Zach Brown authored and Andy Grover committed Sep 9, 2010
1 parent 515e079 commit 80c51be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/rds/threads.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ void rds_threads_exit(void)

int __init rds_threads_init(void)
{
rds_wq = create_workqueue("krdsd");
rds_wq = create_singlethread_workqueue("krdsd");
if (!rds_wq)
return -ENOMEM;

Expand Down

0 comments on commit 80c51be

Please sign in to comment.