Skip to content

Commit

Permalink
perf sched: Make idle thread and comm/pid names more consistent
Browse files Browse the repository at this point in the history
Peter noticed that we have 3 ways of referring to the idle thread:

 [idle]:0
 swapper:0
 swapper-0

Standardize on 'swapper:0'.

Reported-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Sep 16, 2009
1 parent c8a3775 commit 80ed098
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tools/perf/builtin-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -1204,13 +1204,13 @@ static void output_lat_thread(struct work_atoms *work_list)
/*
* Ignore idle threads:
*/
if (!work_list->thread->pid)
if (!strcmp(work_list->thread->comm, "swapper"))
return;

all_runtime += work_list->total_runtime;
all_count += work_list->nb_atoms;

ret = printf(" %s-%d ", work_list->thread->comm, work_list->thread->pid);
ret = printf(" %s:%d ", work_list->thread->comm, work_list->thread->pid);

for (i = 0; i < 24 - ret; i++)
printf(" ");
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/util/thread.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ register_idle_thread(struct rb_root *threads, struct thread **last_match)
{
struct thread *thread = threads__findnew(0, threads, last_match);

if (!thread || thread__set_comm(thread, "[init]")) {
if (!thread || thread__set_comm(thread, "swapper")) {
fprintf(stderr, "problem inserting idle task.\n");
exit(-1);
}
Expand Down

0 comments on commit 80ed098

Please sign in to comment.