Skip to content

Commit

Permalink
staging/rts_pstor: Delete some lines (dev_info() and dev_err()) in rt…
Browse files Browse the repository at this point in the history
…sx.c

fixed some coccinelle warnings.
+ drivers/staging/rts_pstor/rtsx.c:397:16-19: ERROR: dev is NULL but dereferenced.
  drivers/staging/rts_pstor/rtsx.c:447:16-19: ERROR: dev is NULL but dereferenced.
  drivers/staging/rts_pstor/rtsx.c:358:16-19: ERROR: dev is NULL but dereferenced.

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
YAMANE Toshiaki authored and Greg Kroah-Hartman committed Sep 21, 2012
1 parent 428ed14 commit 8143941
Showing 1 changed file with 3 additions and 15 deletions.
18 changes: 3 additions & 15 deletions drivers/staging/rts_pstor/rtsx.c
Original file line number Diff line number Diff line change
Expand Up @@ -352,12 +352,8 @@ static int rtsx_suspend(struct pci_dev *pci, pm_message_t state)
struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci);
struct rtsx_chip *chip;

dev_info(&dev->pci->dev, "Ready to suspend\n");

if (!dev) {
dev_err(&dev->pci->dev, "Invalid memory\n");
if (!dev)
return 0;
}

/* lock the device pointers */
mutex_lock(&(dev->dev_mutex));
Expand Down Expand Up @@ -391,12 +387,8 @@ static int rtsx_resume(struct pci_dev *pci)
struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci);
struct rtsx_chip *chip;

dev_info(&dev->pci->dev, "Ready to resume\n");

if (!dev) {
dev_err(&dev->pci->dev, "Invalid memory\n");
if (!dev)
return 0;
}

chip = dev->chip;

Expand Down Expand Up @@ -441,12 +433,8 @@ static void rtsx_shutdown(struct pci_dev *pci)
struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci);
struct rtsx_chip *chip;

dev_info(&dev->pci->dev, "Ready to shutdown\n");

if (!dev) {
dev_err(&dev->pci->dev, "Invalid memory\n");
if (!dev)
return;
}

chip = dev->chip;

Expand Down

0 comments on commit 8143941

Please sign in to comment.