Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 208269
b: refs/heads/master
c: 2daa672
h: refs/heads/master
i:
  208267: b49e44d
v: v3
  • Loading branch information
Arnd Bergmann authored and Jens Axboe committed Aug 7, 2010
1 parent efde2cf commit 815e2c8
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 6 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 409f3499a2cfcd1e9c2857c53af7fcce069f027f
refs/heads/master: 2daa672b1a736d41b3e7a2e3a05f1909a1f96530
21 changes: 16 additions & 5 deletions trunk/drivers/message/i2o/i2o_block.c
Original file line number Diff line number Diff line change
Expand Up @@ -657,30 +657,40 @@ static int i2o_block_ioctl(struct block_device *bdev, fmode_t mode,
{
struct gendisk *disk = bdev->bd_disk;
struct i2o_block_device *dev = disk->private_data;
int ret = -ENOTTY;

/* Anyone capable of this syscall can do *real bad* things */

if (!capable(CAP_SYS_ADMIN))
return -EPERM;

lock_kernel();
switch (cmd) {
case BLKI2OGRSTRAT:
return put_user(dev->rcache, (int __user *)arg);
ret = put_user(dev->rcache, (int __user *)arg);
break;
case BLKI2OGWSTRAT:
return put_user(dev->wcache, (int __user *)arg);
ret = put_user(dev->wcache, (int __user *)arg);
break;
case BLKI2OSRSTRAT:
ret = -EINVAL;
if (arg < 0 || arg > CACHE_SMARTFETCH)
return -EINVAL;
break;
dev->rcache = arg;
ret = 0;
break;
case BLKI2OSWSTRAT:
ret = -EINVAL;
if (arg != 0
&& (arg < CACHE_WRITETHROUGH || arg > CACHE_SMARTBACK))
return -EINVAL;
break;
dev->wcache = arg;
ret = 0;
break;
}
return -ENOTTY;
unlock_kernel();

return ret;
};

/**
Expand Down Expand Up @@ -936,6 +946,7 @@ static const struct block_device_operations i2o_block_fops = {
.open = i2o_block_open,
.release = i2o_block_release,
.ioctl = i2o_block_ioctl,
.compat_ioctl = i2o_block_ioctl,
.getgeo = i2o_block_getgeo,
.media_changed = i2o_block_media_changed
};
Expand Down

0 comments on commit 815e2c8

Please sign in to comment.