Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 361600
b: refs/heads/master
c: 1ada47d
h: refs/heads/master
v: v3
  • Loading branch information
Theodore Ts'o committed Mar 20, 2013
1 parent 445f1b1 commit 8163f9a
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 5 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 0e401101db49959f5783f6ee9e676124b5a183ac
refs/heads/master: 1ada47d9468fe3907f7f9e00179168f5e2f90803
2 changes: 1 addition & 1 deletion trunk/fs/ext4/ext4.h
Original file line number Diff line number Diff line change
Expand Up @@ -2617,7 +2617,7 @@ extern int ext4_move_extents(struct file *o_filp, struct file *d_filp,
extern int __init ext4_init_pageio(void);
extern void ext4_add_complete_io(ext4_io_end_t *io_end);
extern void ext4_exit_pageio(void);
extern void ext4_ioend_wait(struct inode *);
extern void ext4_ioend_shutdown(struct inode *);
extern void ext4_free_io_end(ext4_io_end_t *io);
extern ext4_io_end_t *ext4_init_io_end(struct inode *inode, gfp_t flags);
extern void ext4_end_io_work(struct work_struct *work);
Expand Down
4 changes: 2 additions & 2 deletions trunk/fs/ext4/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,6 @@ void ext4_evict_inode(struct inode *inode)

trace_ext4_evict_inode(inode);

ext4_ioend_wait(inode);

if (inode->i_nlink) {
/*
* When journalling data dirty buffers are tracked only in the
Expand Down Expand Up @@ -216,6 +214,7 @@ void ext4_evict_inode(struct inode *inode)
filemap_write_and_wait(&inode->i_data);
}
truncate_inode_pages(&inode->i_data, 0);
ext4_ioend_shutdown(inode);
goto no_delete;
}

Expand All @@ -225,6 +224,7 @@ void ext4_evict_inode(struct inode *inode)
if (ext4_should_order_data(inode))
ext4_begin_ordered_truncate(inode, 0);
truncate_inode_pages(&inode->i_data, 0);
ext4_ioend_shutdown(inode);

if (is_bad_inode(inode))
goto no_delete;
Expand Down
12 changes: 11 additions & 1 deletion trunk/fs/ext4/page-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,21 @@ void ext4_exit_pageio(void)
kmem_cache_destroy(io_page_cachep);
}

void ext4_ioend_wait(struct inode *inode)
/*
* This function is called by ext4_evict_inode() to make sure there is
* no more pending I/O completion work left to do.
*/
void ext4_ioend_shutdown(struct inode *inode)
{
wait_queue_head_t *wq = ext4_ioend_wq(inode);

wait_event(*wq, (atomic_read(&EXT4_I(inode)->i_ioend_count) == 0));
/*
* We need to make sure the work structure is finished being
* used before we let the inode get destroyed.
*/
if (work_pending(&EXT4_I(inode)->i_unwritten_work))
cancel_work_sync(&EXT4_I(inode)->i_unwritten_work);
}

static void put_io_page(struct ext4_io_page *io_page)
Expand Down

0 comments on commit 8163f9a

Please sign in to comment.