Skip to content

Commit

Permalink
netdev: Kill qdisc_ingress, use netdev->rx_queue.qdisc instead.
Browse files Browse the repository at this point in the history
Now that our qdisc management is bi-directional, per-queue, and fully
orthogonal, there is no reason to have a special ingress qdisc pointer
in struct net_device.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jul 9, 2008
1 parent b0e1e64 commit 816f325
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
3 changes: 0 additions & 3 deletions include/linux/netdevice.h
Original file line number Diff line number Diff line change
Expand Up @@ -634,9 +634,6 @@ struct net_device

struct netdev_queue rx_queue;
struct netdev_queue tx_queue ____cacheline_aligned_in_smp;

struct Qdisc *qdisc_ingress;

unsigned long tx_queue_len; /* Max frames per queue allowed */

/* Partially transmitted GSO packet. */
Expand Down
4 changes: 2 additions & 2 deletions net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -2033,7 +2033,7 @@ static int ing_filter(struct sk_buff *skb)
rxq = &dev->rx_queue;

spin_lock(&rxq->lock);
if ((q = dev->qdisc_ingress) != NULL)
if ((q = rxq->qdisc) != NULL)
result = q->enqueue(skb, q);
spin_unlock(&rxq->lock);

Expand All @@ -2044,7 +2044,7 @@ static inline struct sk_buff *handle_ing(struct sk_buff *skb,
struct packet_type **pt_prev,
int *ret, struct net_device *orig_dev)
{
if (!skb->dev->qdisc_ingress)
if (!skb->dev->rx_queue.qdisc)
goto out;

if (*pt_prev) {
Expand Down
11 changes: 6 additions & 5 deletions net/sched/sch_api.c
Original file line number Diff line number Diff line change
Expand Up @@ -450,14 +450,15 @@ dev_graft_qdisc(struct net_device *dev, struct Qdisc *qdisc)

qdisc_lock_tree(dev);
if (qdisc && qdisc->flags&TCQ_F_INGRESS) {
oqdisc = dev->qdisc_ingress;
dev_queue = &dev->rx_queue;
oqdisc = dev_queue->qdisc;
/* Prune old scheduler */
if (oqdisc && atomic_read(&oqdisc->refcnt) <= 1) {
/* delete */
qdisc_reset(oqdisc);
dev->qdisc_ingress = NULL;
dev_queue->qdisc = NULL;
} else { /* new */
dev->qdisc_ingress = qdisc;
dev_queue->qdisc = qdisc;
}

} else {
Expand Down Expand Up @@ -739,7 +740,7 @@ static int tc_get_qdisc(struct sk_buff *skb, struct nlmsghdr *n, void *arg)
return -ENOENT;
q = qdisc_leaf(p, clid);
} else { /* ingress */
q = dev->qdisc_ingress;
q = dev->rx_queue.qdisc;
}
} else {
struct netdev_queue *dev_queue = &dev->tx_queue;
Expand Down Expand Up @@ -814,7 +815,7 @@ static int tc_modify_qdisc(struct sk_buff *skb, struct nlmsghdr *n, void *arg)
return -ENOENT;
q = qdisc_leaf(p, clid);
} else { /*ingress */
q = dev->qdisc_ingress;
q = dev->rx_queue.qdisc;
}
} else {
struct netdev_queue *dev_queue = &dev->tx_queue;
Expand Down

0 comments on commit 816f325

Please sign in to comment.