Skip to content

Commit

Permalink
neigh: simplify seq_file code
Browse files Browse the repository at this point in the history
Simpily pass 'struct neigh_table' with seq_file private pointer,
and save one dereference. Proc entry itself isn't interesting.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexey Dobriyan authored and David S. Miller committed Jan 23, 2010
1 parent a271623 commit 81c1ebf
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions net/core/neighbour.c
Original file line number Diff line number Diff line change
Expand Up @@ -2417,8 +2417,7 @@ EXPORT_SYMBOL(neigh_seq_stop);

static void *neigh_stat_seq_start(struct seq_file *seq, loff_t *pos)
{
struct proc_dir_entry *pde = seq->private;
struct neigh_table *tbl = pde->data;
struct neigh_table *tbl = seq->private;
int cpu;

if (*pos == 0)
Expand All @@ -2435,8 +2434,7 @@ static void *neigh_stat_seq_start(struct seq_file *seq, loff_t *pos)

static void *neigh_stat_seq_next(struct seq_file *seq, void *v, loff_t *pos)
{
struct proc_dir_entry *pde = seq->private;
struct neigh_table *tbl = pde->data;
struct neigh_table *tbl = seq->private;
int cpu;

for (cpu = *pos; cpu < nr_cpu_ids; ++cpu) {
Expand All @@ -2455,8 +2453,7 @@ static void neigh_stat_seq_stop(struct seq_file *seq, void *v)

static int neigh_stat_seq_show(struct seq_file *seq, void *v)
{
struct proc_dir_entry *pde = seq->private;
struct neigh_table *tbl = pde->data;
struct neigh_table *tbl = seq->private;
struct neigh_statistics *st = v;

if (v == SEQ_START_TOKEN) {
Expand Down Expand Up @@ -2501,7 +2498,7 @@ static int neigh_stat_seq_open(struct inode *inode, struct file *file)

if (!ret) {
struct seq_file *sf = file->private_data;
sf->private = PDE(inode);
sf->private = PDE(inode)->data;
}
return ret;
};
Expand Down

0 comments on commit 81c1ebf

Please sign in to comment.