Skip to content

Commit

Permalink
net: fix network drivers ndo_start_xmit() return values (part 7)
Browse files Browse the repository at this point in the history
Fix up ATM drivers that return an errno value to qdisc_restart(), causing
qdisc_restart() to print a warning an requeue/retransmit the skb.

- lec: condition can only be remedied by userspace, until that retransmissions

Compile tested only.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Patrick McHardy authored and David S. Miller committed Jun 13, 2009
1 parent 98ca4a4 commit 81fbbf6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/atm/lec.c
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ static int lec_start_xmit(struct sk_buff *skb, struct net_device *dev)
printk("%s:No lecd attached\n", dev->name);
dev->stats.tx_errors++;
netif_stop_queue(dev);
return -EUNATCH;
kfree_skb(skb);
return NETDEV_TX_OK;
}

pr_debug("skbuff head:%lx data:%lx tail:%lx end:%lx\n",
Expand Down

0 comments on commit 81fbbf6

Please sign in to comment.