Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 147038
b: refs/heads/master
c: 4f23122
h: refs/heads/master
v: v3
  • Loading branch information
Jens Axboe committed May 13, 2009
1 parent 1ea4aa6 commit 820a164
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 2b1ccc0ee918a653d0483fdad9dd6112ce8e9043
refs/heads/master: 4f23122858a27ba97444b9b37a066d83edebd4c8
10 changes: 4 additions & 6 deletions trunk/fs/splice.c
Original file line number Diff line number Diff line change
Expand Up @@ -580,13 +580,13 @@ ssize_t default_file_splice_read(struct file *in, loff_t *ppos,
for (i = 0; i < nr_pages && i < PIPE_BUFFERS && len; i++) {
struct page *page;

page = alloc_page(GFP_HIGHUSER);
page = alloc_page(GFP_USER);
error = -ENOMEM;
if (!page)
goto err;

this_len = min_t(size_t, len, PAGE_CACHE_SIZE - offset);
vec[i].iov_base = (void __user *) kmap(page);
vec[i].iov_base = (void __user *) page_address(page);
vec[i].iov_len = this_len;
pages[i] = page;
spd.nr_pages++;
Expand All @@ -604,7 +604,6 @@ ssize_t default_file_splice_read(struct file *in, loff_t *ppos,

nr_freed = 0;
for (i = 0; i < spd.nr_pages; i++) {
kunmap(pages[i]);
this_len = min_t(size_t, vec[i].iov_len, res);
partial[i].offset = 0;
partial[i].len = this_len;
Expand All @@ -624,10 +623,9 @@ ssize_t default_file_splice_read(struct file *in, loff_t *ppos,
return res;

err:
for (i = 0; i < spd.nr_pages; i++) {
kunmap(pages[i]);
for (i = 0; i < spd.nr_pages; i++)
__free_page(pages[i]);
}

return error;
}
EXPORT_SYMBOL(default_file_splice_read);
Expand Down

0 comments on commit 820a164

Please sign in to comment.