Skip to content

Commit

Permalink
[PATCH] This patch contains the following cleanups:
Browse files Browse the repository at this point in the history
- cluster/sys.c: make needlessly global code static
- dlm/: "extern" declarations for variables belong into header files
        (and in this case, they are already in dlmdomain.h)

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
  • Loading branch information
Adrian Bunk authored and Joel Becker committed Jan 3, 2006
1 parent b4e40a5 commit 82353b5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
4 changes: 2 additions & 2 deletions fs/ocfs2/cluster/sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ static ssize_t o2cb_interface_revision_show(char *buf)
return snprintf(buf, PAGE_SIZE, "%u\n", O2NM_API_VERSION);
}

O2CB_ATTR(interface_revision, S_IFREG | S_IRUGO, o2cb_interface_revision_show, NULL);
static O2CB_ATTR(interface_revision, S_IFREG | S_IRUGO, o2cb_interface_revision_show, NULL);

static struct attribute *o2cb_attrs[] = {
&o2cb_attr_interface_revision.attr,
Expand All @@ -73,7 +73,7 @@ static struct kobj_type o2cb_subsys_type = {
};

/* gives us o2cb_subsys */
decl_subsys(o2cb, NULL, NULL);
static decl_subsys(o2cb, NULL, NULL);

static ssize_t
o2cb_show(struct kobject * kobj, struct attribute * attr, char * buffer)
Expand Down
4 changes: 1 addition & 3 deletions fs/ocfs2/dlm/dlmmaster.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
#include "dlmapi.h"
#include "dlmcommon.h"
#include "dlmdebug.h"
#include "dlmdomain.h"

#define MLOG_MASK_PREFIX (ML_DLM|ML_DLM_MASTER)
#include "cluster/masklog.h"
Expand Down Expand Up @@ -178,9 +179,6 @@ static void dlm_dump_mles(struct dlm_ctxt *dlm)
spin_unlock(&dlm->master_lock);
}

extern spinlock_t dlm_domain_lock;
extern struct list_head dlm_domains;

int dlm_dump_all_mles(const char __user *data, unsigned int len)
{
struct list_head *iter;
Expand Down
3 changes: 0 additions & 3 deletions fs/ocfs2/dlm/dlmthread.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@
#define MLOG_MASK_PREFIX (ML_DLM|ML_DLM_THREAD)
#include "cluster/masklog.h"

extern spinlock_t dlm_domain_lock;
extern struct list_head dlm_domains;

static int dlm_thread(void *data);

static void dlm_flush_asts(struct dlm_ctxt *dlm);
Expand Down

0 comments on commit 82353b5

Please sign in to comment.