Skip to content

Commit

Permalink
powerpc/eeh: Display eeh error location for bus and device
Browse files Browse the repository at this point in the history
  For adapters which have devices under a PCIe switch/bridge it is informative
  to display information for both the PCIe switch/bridge and the device on
  which the bus error was detected.

  rebased to powerpc-next

Signed-off-by: Richard A Lary <rlary@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
  • Loading branch information
Richard A Lary authored and Benjamin Herrenschmidt committed May 6, 2011
1 parent 40bd587 commit 82578e1
Showing 1 changed file with 13 additions and 9 deletions.
22 changes: 13 additions & 9 deletions arch/powerpc/platforms/pseries/eeh_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ struct pci_dn * handle_eeh_events (struct eeh_event *event)
struct pci_bus *frozen_bus;
int rc = 0;
enum pci_ers_result result = PCI_ERS_RESULT_NONE;
const char *location, *pci_str, *drv_str;
const char *location, *pci_str, *drv_str, *bus_pci_str, *bus_drv_str;

frozen_dn = find_device_pe(event->dn);
if (!frozen_dn) {
Expand Down Expand Up @@ -364,22 +364,26 @@ struct pci_dn * handle_eeh_events (struct eeh_event *event)
frozen_pdn = PCI_DN(frozen_dn);
frozen_pdn->eeh_freeze_count++;

if (frozen_pdn->pcidev) {
pci_str = pci_name (frozen_pdn->pcidev);
drv_str = pcid_name (frozen_pdn->pcidev);
} else {
pci_str = eeh_pci_name(event->dev);
drv_str = pcid_name (event->dev);
}
pci_str = eeh_pci_name(event->dev);
drv_str = pcid_name(event->dev);

if (frozen_pdn->eeh_freeze_count > EEH_MAX_ALLOWED_FREEZES)
goto excess_failures;

printk(KERN_WARNING
"EEH: This PCI device has failed %d times in the last hour:\n",
frozen_pdn->eeh_freeze_count);

if (frozen_pdn->pcidev) {
bus_pci_str = pci_name(frozen_pdn->pcidev);
bus_drv_str = pcid_name(frozen_pdn->pcidev);
printk(KERN_WARNING
"EEH: Bus location=%s driver=%s pci addr=%s\n",
location, bus_drv_str, bus_pci_str);
}

printk(KERN_WARNING
"EEH: location=%s driver=%s pci addr=%s\n",
"EEH: Device location=%s driver=%s pci addr=%s\n",
location, drv_str, pci_str);

/* Walk the various device drivers attached to this slot through
Expand Down

0 comments on commit 82578e1

Please sign in to comment.