Skip to content

Commit

Permalink
irda: vlsi_ir: remove unnecessary pci_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jingoo Han authored and David S. Miller committed Dec 9, 2013
1 parent 12c51e1 commit 825d15d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/irda/vlsi_ir.c
Original file line number Diff line number Diff line change
Expand Up @@ -1693,7 +1693,6 @@ vlsi_irda_probe(struct pci_dev *pdev, const struct pci_device_id *id)
out_disable:
pci_disable_device(pdev);
out:
pci_set_drvdata(pdev, NULL);
return -ENODEV;
}

Expand All @@ -1719,8 +1718,6 @@ static void vlsi_irda_remove(struct pci_dev *pdev)

free_netdev(ndev);

pci_set_drvdata(pdev, NULL);

IRDA_MESSAGE("%s: %s removed\n", drivername, pci_name(pdev));
}

Expand Down

0 comments on commit 825d15d

Please sign in to comment.