Skip to content

Commit

Permalink
drm/nvc0/dmaobj: stub bind function for now so we can call unconditio…
Browse files Browse the repository at this point in the history
…nally

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
  • Loading branch information
Ben Skeggs committed Nov 28, 2012
1 parent 6c1689a commit 82d23ae
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 6 deletions.
23 changes: 23 additions & 0 deletions drivers/gpu/drm/nouveau/core/engine/dmaobj/nvc0.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,35 @@
*/

#include <core/device.h>
#include <core/gpuobj.h>
#include <core/class.h>

#include <subdev/fb.h>
#include <engine/dmaobj.h>

struct nvc0_dmaeng_priv {
struct nouveau_dmaeng base;
};

static int
nvc0_dmaobj_bind(struct nouveau_dmaeng *dmaeng,
struct nouveau_object *parent,
struct nouveau_dmaobj *dmaobj,
struct nouveau_gpuobj **pgpuobj)
{
int ret = 0;

if (!nv_iclass(parent, NV_ENGCTX_CLASS)) {
switch (nv_mclass(parent->parent)) {
default:
return -EINVAL;
}
} else
return 0;

return ret;
}

static int
nvc0_dmaeng_ctor(struct nouveau_object *parent, struct nouveau_object *engine,
struct nouveau_oclass *oclass, void *data, u32 size,
Expand All @@ -44,6 +66,7 @@ nvc0_dmaeng_ctor(struct nouveau_object *parent, struct nouveau_object *engine,
return ret;

nv_engine(priv)->sclass = nouveau_dmaobj_sclass;
priv->base.bind = nvc0_dmaobj_bind;
return 0;
}

Expand Down
9 changes: 3 additions & 6 deletions drivers/gpu/drm/nouveau/core/engine/fifo/base.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,9 @@ nouveau_fifo_channel_create_(struct nouveau_object *parent,
return -EINVAL;
}

if (dmaeng->bind) {
ret = dmaeng->bind(dmaeng, parent, chan->pushdma,
&chan->pushgpu);
if (ret)
return ret;
}
ret = dmaeng->bind(dmaeng, parent, chan->pushdma, &chan->pushgpu);
if (ret)
return ret;

/* find a free fifo channel */
spin_lock_irqsave(&priv->lock, flags);
Expand Down

0 comments on commit 82d23ae

Please sign in to comment.