Skip to content

Commit

Permalink
drm/i915: Avoid using msleep under kdb and wait_for()
Browse files Browse the repository at this point in the history
wait_for() uses msleep() to yield the cpu whilst spinning waiting for a
register to change. kdb asserts that mode changes are atomic and so
prohibits msleep. The alternative would be to use mdelay or to simply
probe the register more often instead of busy waiting.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Chris Wilson committed Sep 8, 2010
1 parent 481b6af commit 82d7c9e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/intel_drv.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
ret__ = -ETIMEDOUT; \
break; \
} \
if (W) msleep(W); \
if (W && !in_dbg_master()) msleep(W); \
} \
ret__; \
})
Expand Down

0 comments on commit 82d7c9e

Please sign in to comment.