Skip to content

Commit

Permalink
pasemi_mac: Print warning when not attaching to a PHY
Browse files Browse the repository at this point in the history
pasemi_mac: Print warning when not attaching to a PHY

Print a warning on the console when not connecting to a phy for an interface.
It turns out to be a pretty common problem when someone gets the MDIO info
wrong in their device tree, resulting in the macs running at a fixed 1Gbit FD.

Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Olof Johansson authored and David S. Miller committed Jan 28, 2008
1 parent 5d89494 commit 8304b63
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/net/pasemi_mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1064,11 +1064,12 @@ static int pasemi_mac_open(struct net_device *dev)
write_mac_reg(mac, PAS_MAC_CFG_PCFG, flags);

ret = pasemi_mac_phy_init(dev);
/* Some configs don't have PHYs (XAUI etc), so don't complain about
* failed init due to -ENODEV.
/* Warn for missing PHY on SGMII (1Gig) ports.
*/
if (ret && ret != -ENODEV)
dev_warn(&mac->pdev->dev, "phy init failed: %d\n", ret);
if (ret && mac->type == MAC_TYPE_GMAC) {
dev_warn(&mac->pdev->dev, "PHY init failed: %d.\n", ret);
dev_warn(&mac->pdev->dev, "Defaulting to 1Gbit full duplex\n");
}

netif_start_queue(dev);
napi_enable(&mac->napi);
Expand Down

0 comments on commit 8304b63

Please sign in to comment.