Skip to content

Commit

Permalink
powerpc/powernv: Check OPAL dump calls exist before using
Browse files Browse the repository at this point in the history
Check that the OPAL_DUMP_READ token exists before initalising the elog
infrastructure.

This avoids littering the OPAL console with:
  "OPAL: Called with bad token 91"

Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Michael Neuling authored and Michael Ellerman committed Sep 25, 2014
1 parent 7dc992e commit 831cf65
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions arch/powerpc/platforms/powernv/opal-dump.c
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,10 @@ void __init opal_platform_dump_init(void)
{
int rc;

/* ELOG not supported by firmware */
if (!opal_check_token(OPAL_DUMP_READ))
return;

dump_kset = kset_create_and_add("dump", NULL, opal_kobj);
if (!dump_kset) {
pr_warn("%s: Failed to create dump kset\n", __func__);
Expand Down

0 comments on commit 831cf65

Please sign in to comment.