Skip to content

Commit

Permalink
USB: omninet: fix potential tty NULL dereference
Browse files Browse the repository at this point in the history
Add check for return value of tty_port_tty_get,
since it can return NULL after port hangup that may happen anytime.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Alexey Khoroshilov authored and Greg Kroah-Hartman committed Sep 14, 2012
1 parent 17e6791 commit 8321652
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/usb/serial/omninet.c
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,12 @@ static void omninet_read_bulk_callback(struct urb *urb)

if (urb->actual_length && header->oh_len) {
struct tty_struct *tty = tty_port_tty_get(&port->port);
tty_insert_flip_string(tty, data + OMNINET_DATAOFFSET,
if (tty) {
tty_insert_flip_string(tty, data + OMNINET_DATAOFFSET,
header->oh_len);
tty_flip_buffer_push(tty);
tty_kref_put(tty);
tty_flip_buffer_push(tty);
tty_kref_put(tty);
}
}

/* Continue trying to always read */
Expand Down

0 comments on commit 8321652

Please sign in to comment.