Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 338629
b: refs/heads/master
c: 0f9df93
h: refs/heads/master
i:
  338627: 014dce2
v: v3
  • Loading branch information
Sebastian Andrzej Siewior authored and Felipe Balbi committed Oct 31, 2012
1 parent ae4f4b4 commit 8367bf6
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 19 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d0eca719dd11ad0619e8dd6a1f3eceb95b0216dd
refs/heads/master: 0f9df939385527049c8062a099fbfa1479fe7ce0
39 changes: 21 additions & 18 deletions trunk/drivers/usb/gadget/f_uvc.c
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,6 @@ uvc_register_video(struct uvc_device *uvc)
return -ENOMEM;

video->parent = &cdev->gadget->dev;
video->minor = -1;
video->fops = &uvc_v4l2_fops;
video->release = video_device_release;
strncpy(video->name, cdev->gadget->name, sizeof(video->name));
Expand Down Expand Up @@ -577,23 +576,12 @@ uvc_function_unbind(struct usb_configuration *c, struct usb_function *f)

INFO(cdev, "uvc_function_unbind\n");

if (uvc->vdev) {
if (uvc->vdev->minor == -1)
video_device_release(uvc->vdev);
else
video_unregister_device(uvc->vdev);
uvc->vdev = NULL;
}

if (uvc->control_ep)
uvc->control_ep->driver_data = NULL;
if (uvc->video.ep)
uvc->video.ep->driver_data = NULL;
video_unregister_device(uvc->vdev);
uvc->control_ep->driver_data = NULL;
uvc->video.ep->driver_data = NULL;

if (uvc->control_req) {
usb_ep_free_request(cdev->gadget->ep0, uvc->control_req);
kfree(uvc->control_buf);
}
usb_ep_free_request(cdev->gadget->ep0, uvc->control_req);
kfree(uvc->control_buf);

kfree(f->descriptors);
kfree(f->hs_descriptors);
Expand Down Expand Up @@ -740,7 +728,22 @@ uvc_function_bind(struct usb_configuration *c, struct usb_function *f)
return 0;

error:
uvc_function_unbind(c, f);
if (uvc->vdev)
video_device_release(uvc->vdev);

if (uvc->control_ep)
uvc->control_ep->driver_data = NULL;
if (uvc->video.ep)
uvc->video.ep->driver_data = NULL;

if (uvc->control_req) {
usb_ep_free_request(cdev->gadget->ep0, uvc->control_req);
kfree(uvc->control_buf);
}

kfree(f->descriptors);
kfree(f->hs_descriptors);
kfree(f->ss_descriptors);
return ret;
}

Expand Down

0 comments on commit 8367bf6

Please sign in to comment.