Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 75775
b: refs/heads/master
c: 4443d07
h: refs/heads/master
i:
  75773: 68310f1
  75771: 1321dab
  75767: aeff252
  75759: a813a74
  75743: df60b6e
  75711: 0e421ea
  75647: 23cc001
  75519: b8e1b9d
  75263: 37a838c
  74751: 457e822
  73727: 03c81e4
v: v3
  • Loading branch information
Greg Kroah-Hartman committed Jan 25, 2008
1 parent 7357b58 commit 83ddbd3
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 18 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 7f548217860a7cf8a345d87792a07512450dfbff
refs/heads/master: 4443d07fcfab39c4d2d9d7711cff983f15b374fc
38 changes: 21 additions & 17 deletions trunk/drivers/parisc/pdc_stable.c
Original file line number Diff line number Diff line change
Expand Up @@ -960,8 +960,8 @@ static struct attribute_group pdcs_attr_group = {
.attrs = pdcs_subsys_attrs,
};

static decl_subsys(paths, NULL);
static decl_subsys(stable, NULL);
static struct kset *stable_kset;
static struct kset *paths_kset;

/**
* pdcs_register_pathentries - Prepares path entries kobjects for sysfs usage.
Expand Down Expand Up @@ -993,7 +993,7 @@ pdcs_register_pathentries(void)

if ((err = kobject_set_name(&entry->kobj, "%s", entry->name)))
return err;
entry->kobj.kset = &paths_subsys;
entry->kobj.kset = paths_kset;
entry->kobj.ktype = &ktype_pdcspath;
if ((err = kobject_register(&entry->kobj)))
return err;
Expand Down Expand Up @@ -1058,30 +1058,35 @@ pdc_stable_init(void)
/* the actual result is 16 bits away */
pdcs_osid = (u16)(result >> 16);

/* For now we'll register the stable subsys within this driver */
if ((rc = firmware_register(&stable_subsys)))
/* For now we'll register the stable kset within this driver */
stable_kset = kset_create_and_add("stable", NULL, &firmware_kset->kobj);
if (!stable_kset) {
rc = -ENOMEM;
goto fail_firmreg;
}

/* Don't forget the root entries */
error = sysfs_create_group(&stable_subsys.kobj, pdcs_attr_group);
error = sysfs_create_group(&stable_kset->kobj, pdcs_attr_group);

/* register the paths subsys as a subsystem of stable subsys */
paths_subsys.kobj.kset = &stable_subsys;
if ((rc = subsystem_register(&paths_subsys)))
goto fail_subsysreg;
/* register the paths kset as a child of the stable kset */
paths_kset = kset_create_and_add("paths", NULL, &stable_kset->kobj);
if (!paths_kset) {
rc = -ENOMEM;
goto fail_ksetreg;
}

/* now we create all "files" for the paths subsys */
/* now we create all "files" for the paths kset */
if ((rc = pdcs_register_pathentries()))
goto fail_pdcsreg;

return rc;

fail_pdcsreg:
pdcs_unregister_pathentries();
subsystem_unregister(&paths_subsys);
kset_unregister(paths_kset);

fail_subsysreg:
firmware_unregister(&stable_subsys);
fail_ksetreg:
kset_unregister(stable_kset);

fail_firmreg:
printk(KERN_INFO PDCS_PREFIX " bailing out\n");
Expand All @@ -1092,9 +1097,8 @@ static void __exit
pdc_stable_exit(void)
{
pdcs_unregister_pathentries();
subsystem_unregister(&paths_subsys);

firmware_unregister(&stable_subsys);
kset_unregister(paths_kset);
kset_unregister(stable_kset);
}


Expand Down

0 comments on commit 83ddbd3

Please sign in to comment.