Skip to content

Commit

Permalink
OMAPDSS: APPLY: add dss_apply_ovl_enable()
Browse files Browse the repository at this point in the history
Add a helper function dss_apply_ovl_enable(), which is similar to the
main apply() function: dss_apply_ovl_enable() applies the given overlay
enable-status to ovl_priv_data, and sets the dirty flag.

The difference between the helper function and the previous direct use
of the fields is that the helper function will not do anything if the
enable state is already the same as given in the parameter.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
Tomi Valkeinen committed Dec 2, 2011
1 parent ff4733d commit 841c09c
Showing 1 changed file with 15 additions and 4 deletions.
19 changes: 15 additions & 4 deletions drivers/video/omap2/dss/apply.c
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,19 @@ int omap_dss_mgr_apply(struct omap_overlay_manager *mgr)
return r;
}

static void dss_apply_ovl_enable(struct omap_overlay *ovl, bool enable)
{
struct ovl_priv_data *op;

op = get_ovl_priv(ovl);

if (op->enabled == enable)
return;

op->enabled = enable;
op->extra_info_dirty = true;
}

static void dss_ovl_setup_fifo(struct omap_overlay *ovl)
{
struct ovl_priv_data *op = get_ovl_priv(ovl);
Expand Down Expand Up @@ -999,8 +1012,7 @@ int dss_ovl_enable(struct omap_overlay *ovl)

spin_lock_irqsave(&data_lock, flags);

op->enabled = true;
op->extra_info_dirty = true;
dss_apply_ovl_enable(ovl, true);

dss_ovl_setup_fifo(ovl);

Expand Down Expand Up @@ -1031,8 +1043,7 @@ int dss_ovl_disable(struct omap_overlay *ovl)

spin_lock_irqsave(&data_lock, flags);

op->enabled = false;
op->extra_info_dirty = true;
dss_apply_ovl_enable(ovl, false);

dss_write_regs();

Expand Down

0 comments on commit 841c09c

Please sign in to comment.