Skip to content

Commit

Permalink
KVM: remove the IRQ ACK notifier assertions
Browse files Browse the repository at this point in the history
We will obviously never pass a NULL struct kvm_irq_ack_notifier* to
this functions. They are always embedded in the assigned device
structure, so the assertion add nothing.

The irqchip_in_kernel() assertion is very out of place - clearly
this little abstraction needs to know nothing about the upper
layer details.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
Mark McLoughlin authored and Avi Kivity committed Dec 31, 2008
1 parent efff9e5 commit 844c7a9
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions virt/kvm/irq_comm.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ void kvm_notify_acked_irq(struct kvm *kvm, unsigned gsi)
void kvm_register_irq_ack_notifier(struct kvm *kvm,
struct kvm_irq_ack_notifier *kian)
{
/* Must be called with in-kernel IRQ chip, otherwise it's nonsense */
ASSERT(irqchip_in_kernel(kvm));
ASSERT(kian);
hlist_add_head(&kian->link, &kvm->arch.irq_ack_notifier_list);
}

Expand Down

0 comments on commit 844c7a9

Please sign in to comment.