Skip to content

Commit

Permalink
ARM: OMAP3: Clean up spurious interrupt check logic
Browse files Browse the repository at this point in the history
SPURIOUSIRQ is contained in bits 31:7 of INTC_SIR, so
INTC_SIR must be right shifted by 7, not 6.

No change in logic, only changes for better readability.
Refer to register definition of INTCPS_SIR_IRQ in OMAP3 Manual.

Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
  • Loading branch information
Roger Quadros authored and Tony Lindgren committed Apr 23, 2009
1 parent bedfd15 commit 846c29f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/arm/mach-omap2/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ static int omap_check_spurious(unsigned int irq)
u32 sir, spurious;

sir = intc_bank_read_reg(&irq_banks[0], INTC_SIR);
spurious = sir >> 6;
spurious = sir >> 7;

if (spurious > 1) {
if (spurious) {
printk(KERN_WARNING "Spurious irq %i: 0x%08x, please flush "
"posted write for irq %i\n",
irq, sir, previous_irq);
Expand Down

0 comments on commit 846c29f

Please sign in to comment.