Skip to content

Commit

Permalink
x86, signals: remove duplicated register setup code in ia32 signal de…
Browse files Browse the repository at this point in the history
…livery

Impact: cleanup, no functionality changed

ia32_setup_rt_frame() has a duplicated code block labelled
"Make -mregparm=3 work" for setting up the register parameters
to the user-mode signal handler.

This is harmless but ugly. Remove the redundant assignments.

Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Mikael Pettersson authored and Ingo Molnar committed Oct 27, 2008
1 parent f8d56f1 commit 8479d94
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions arch/x86/ia32/ia32_signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -572,11 +572,6 @@ int ia32_setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
regs->dx = (unsigned long) &frame->info;
regs->cx = (unsigned long) &frame->uc;

/* Make -mregparm=3 work */
regs->ax = sig;
regs->dx = (unsigned long) &frame->info;
regs->cx = (unsigned long) &frame->uc;

loadsegment(ds, __USER32_DS);
loadsegment(es, __USER32_DS);

Expand Down

0 comments on commit 8479d94

Please sign in to comment.