Skip to content

Commit

Permalink
gpio/langwell: Clear edge bit before handling
Browse files Browse the repository at this point in the history
I don't have the specs for this beast, but it looks a lot like the PXA
GPIO block. Though I bet it's the same IP and the driver should have
reused the PXA code.

Acknowleding the edge detect status after handling one or more gpio
interrupts looks wrong. We might lose an edge which came in while we
handled the previous one.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Alek Du <alek.du@intel.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Thomas Gleixner authored and Grant Likely committed Mar 18, 2011
1 parent 732063b commit 84bead6
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions drivers/gpio/langwell_gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -190,23 +190,22 @@ static void lnw_irq_handler(unsigned irq, struct irq_desc *desc)
struct irq_data *data = irq_desc_get_irq_data(desc);
struct lnw_gpio *lnw = irq_data_get_irq_handler_data(data);
struct irq_chip *chip = irq_data_get_irq_chip(data);
u32 base, gpio, gedr_v;
u32 base, gpio, mask;
unsigned long pending;
void __iomem *gedr;

/* check GPIO controller to check which pin triggered the interrupt */
for (base = 0; base < lnw->chip.ngpio; base += 32) {
gedr = gpio_reg(&lnw->chip, base, GEDR);
gedr_v = pending = readl(gedr);
if (!gedr_v)
continue;
pending = readl(gedr);
while (pending) {
gpio = __ffs(pending) - 1;
pending &= ~BIT(gpio);
mask = BIT(gpio);
pending &= ~mask;
/* Clear before handling so we can't lose an edge */
writel(mask, gedr);
generic_handle_irq(lnw->irq_base + base + gpio);
}
/* clear the edge detect status bit */
writel(gedr_v, gedr);
}

chip->irq_eoi(data);
Expand Down

0 comments on commit 84bead6

Please sign in to comment.