Skip to content

Commit

Permalink
[media] v4l: Replace enums with fixed-sized fields in public structure
Browse files Browse the repository at this point in the history
The v4l2_mbus_framefmt structure will be part of the public userspace
API and used (albeit indirectly) as an ioctl argument. As such, its size
must be fixed across userspace ABIs.

Replace the v4l2_field and v4l2_colorspace enums by __u32 fields and add
padding for future enhancements.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Laurent Pinchart authored and Mauro Carvalho Chehab committed Mar 22, 2011
1 parent 2ef2d5a commit 84d0688
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions include/linux/v4l2-mediabus.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,17 @@ enum v4l2_mbus_pixelcode {
* struct v4l2_mbus_framefmt - frame format on the media bus
* @width: frame width
* @height: frame height
* @code: data format code
* @field: used interlacing type
* @colorspace: colorspace of the data
* @code: data format code (from enum v4l2_mbus_pixelcode)
* @field: used interlacing type (from enum v4l2_field)
* @colorspace: colorspace of the data (from enum v4l2_colorspace)
*/
struct v4l2_mbus_framefmt {
__u32 width;
__u32 height;
__u32 code;
enum v4l2_field field;
enum v4l2_colorspace colorspace;
__u32 width;
__u32 height;
__u32 code;
__u32 field;
__u32 colorspace;
__u32 reserved[7];
};

#endif

0 comments on commit 84d0688

Please sign in to comment.