Skip to content

Commit

Permalink
[PATCH] x86-64: Put more than one cpu in TARGET_CPUS
Browse files Browse the repository at this point in the history
TARGET_CPUS is the default irq routing poicy.  It specifies which cpus the
kernel should aim an irq at.  In physflat delivery mode we can route an irq to
a single cpu.  But that doesn't mean our default policy should only be a
single cpu is allowed.

By allowing the irq routing code to select from multiple cpus this enables
systems with more irqs then we can service on a single processor to actually
work.

I just audited and tested the code and irqbalance doesn't care, and the
io_apic.c doesn't care if we have extra cpus in the mask.  Everything will use
or assume we are using the lowest numbered cpu in the mask if we can't use
them all.

So this should result in no behavior changes except on systems that need it.

Thanks for YH Lu for spotting this problem in his testing.

Cc: Yinghai Lu <yinghai.lu@amd.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Andi Kleen <ak@suse.de>
  • Loading branch information
Eric W. Biederman authored and Andi Kleen committed Oct 21, 2006
1 parent 8cf2c51 commit 84f404f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86_64/kernel/genapic_flat.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ struct genapic apic_flat = {

static cpumask_t physflat_target_cpus(void)
{
return cpumask_of_cpu(0);
return cpu_online_map;
}

static cpumask_t physflat_vector_allocation_domain(int cpu)
Expand Down

0 comments on commit 84f404f

Please sign in to comment.