Skip to content

Commit

Permalink
PCI: fix conflict between SR-IOV and config space sizing
Browse files Browse the repository at this point in the history
New pci_cfg_space_size() needs invalid pdev->class, put it in the
right place in the pci_setup_device().

Signed-off-by: Yu Zhao <yu.zhao@intel.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Yu Zhao authored and Jesse Barnes committed Mar 26, 2009
1 parent ceb93a9 commit 853346e
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/pci/probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,6 @@ int pci_setup_device(struct pci_dev *dev)
dev->dev.bus = &pci_bus_type;
dev->hdr_type = hdr_type & 0x7f;
dev->multifunction = !!(hdr_type & 0x80);
dev->cfg_size = pci_cfg_space_size(dev);
dev->error_state = pci_channel_io_normal;
set_pcie_port_type(dev);

Expand All @@ -738,6 +737,9 @@ int pci_setup_device(struct pci_dev *dev)
dev_dbg(&dev->dev, "found [%04x:%04x] class %06x header type %02x\n",
dev->vendor, dev->device, class, dev->hdr_type);

/* need to have dev->class ready */
dev->cfg_size = pci_cfg_space_size(dev);

/* "Unknown power state" */
dev->current_state = PCI_UNKNOWN;

Expand Down Expand Up @@ -959,9 +961,6 @@ static struct pci_dev *pci_scan_device(struct pci_bus *bus, int devfn)
return NULL;
}

/* need to have dev->class ready */
dev->cfg_size = pci_cfg_space_size(dev);

return dev;
}

Expand Down

0 comments on commit 853346e

Please sign in to comment.