Skip to content

Commit

Permalink
[S390] cio: Fix inverted isc priorities.
Browse files Browse the repository at this point in the history
Priorities for I/O interruption subclasses range from 0 (highest)
to 7 (lowest). Unfortunately, the console has been using isc 7
instead of an isc with a higher priority than regular I/O
subchannels (which use 3). Fix this by making the console use
isc 1.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Cornelia Huck authored and Martin Schwidefsky committed Jun 10, 2008
1 parent ee0ddad commit 85b0d7c
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions drivers/s390/cio/cio.c
Original file line number Diff line number Diff line change
Expand Up @@ -576,12 +576,14 @@ cio_validate_subchannel (struct subchannel *sch, struct subchannel_id schid)
err = -ENODEV;
goto out;
}
if (cio_is_console(sch->schid))
if (cio_is_console(sch->schid)) {
sch->opm = 0xff;
else
sch->isc = 1;
} else {
sch->opm = chp_get_sch_opm(sch);
sch->isc = 3;
}
sch->lpm = sch->schib.pmcw.pam & sch->opm;
sch->isc = 3;

CIO_MSG_EVENT(6, "Detected device %04x on subchannel 0.%x.%04X "
"- PIM = %02X, PAM = %02X, POM = %02X\n",
Expand Down Expand Up @@ -704,9 +706,9 @@ void wait_cons_dev(void)
if (!console_subchannel_in_use)
return;

/* disable all but isc 7 (console device) */
/* disable all but isc 1 (console device) */
__ctl_store (save_cr6, 6, 6);
cr6 = 0x01000000;
cr6 = 0x40000000;
__ctl_load (cr6, 6, 6);

do {
Expand Down Expand Up @@ -788,11 +790,11 @@ cio_probe_console(void)
}

/*
* enable console I/O-interrupt subclass 7
* enable console I/O-interrupt subclass 1
*/
ctl_set_bit(6, 24);
console_subchannel.isc = 7;
console_subchannel.schib.pmcw.isc = 7;
ctl_set_bit(6, 30);
console_subchannel.isc = 1;
console_subchannel.schib.pmcw.isc = 1;
console_subchannel.schib.pmcw.intparm =
(u32)(addr_t)&console_subchannel;
ret = cio_modify(&console_subchannel);
Expand Down

0 comments on commit 85b0d7c

Please sign in to comment.