Skip to content

Commit

Permalink
pinctrl/u300/coh901: stop spawning pinctrl from GPIO
Browse files Browse the repository at this point in the history
Let's stop spawning the pinctrl driver from the GPIO driver,
we have these two mechanisms broken apart now, and they can
each probe in isolation. If the GPIO driver cannot find its
pin controller (pinctrl-u300), the pin controller core will
tell it to defer probing.

Reviewed-by: Stephen Warren <swarren@nvidia.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Linus Walleij committed Nov 21, 2012
1 parent 387923c commit 8604ac3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion arch/arm/mach-u300/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1445,7 +1445,6 @@ static struct platform_device pinctrl_device = {
static struct u300_gpio_platform u300_gpio_plat = {
.ports = 7,
.gpio_base = 0,
.pinctrl_device = &pinctrl_device,
};

static struct platform_device gpio_device = {
Expand Down Expand Up @@ -1589,6 +1588,7 @@ static struct platform_device *platform_devs[] __initdata = {
&i2c1_device,
&keypad_device,
&rtc_device,
&pinctrl_device,
&gpio_device,
&nand_device,
&wdog_device,
Expand Down
6 changes: 0 additions & 6 deletions drivers/pinctrl/pinctrl-coh901.c
Original file line number Diff line number Diff line change
Expand Up @@ -816,11 +816,6 @@ static int __init u300_gpio_probe(struct platform_device *pdev)
goto err_no_chip;
}

/* Spawn pin controller device as child of the GPIO */
err = platform_device_register(plat->pinctrl_device);
if (err)
goto err_no_pinctrl;

/*
* Add pinctrl pin ranges, the pin controller must be registered
* at this point
Expand All @@ -839,7 +834,6 @@ static int __init u300_gpio_probe(struct platform_device *pdev)
return 0;

err_no_range:
err_no_pinctrl:
err = gpiochip_remove(&gpio->chip);
err_no_chip:
err_no_domain:
Expand Down
2 changes: 0 additions & 2 deletions include/linux/platform_data/pinctrl-coh901.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,10 @@
* struct u300_gpio_platform - U300 GPIO platform data
* @ports: number of GPIO block ports
* @gpio_base: first GPIO number for this block (use a free range)
* @pinctrl_device: pin control device to spawn as child
*/
struct u300_gpio_platform {
u8 ports;
int gpio_base;
struct platform_device *pinctrl_device;
};

#endif /* __MACH_U300_GPIO_U300_H */

0 comments on commit 8604ac3

Please sign in to comment.