Skip to content

Commit

Permalink
mac80211: fix WMM AC default for non-QoS data frames
Browse files Browse the repository at this point in the history
The WMM AC selection added to the monitor mode selection function
accidentally assigns non-QoS data frames to the same AC as mgmt frames
(VO). This is not serious, but should be fixed anyway. This patch
assigns them to the BE AC instead.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Felix Fietkau authored and John W. Linville committed Jan 19, 2010
1 parent 031cf0e commit 861a57c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion net/mac80211/iface.c
Original file line number Diff line number Diff line change
Expand Up @@ -695,10 +695,14 @@ static u16 ieee80211_monitor_select_queue(struct net_device *dev,

hdr = (void *)((u8 *)skb->data + le16_to_cpu(rtap->it_len));

if (!ieee80211_is_data_qos(hdr->frame_control)) {
if (!ieee80211_is_data(hdr->frame_control)) {
skb->priority = 7;
return ieee802_1d_to_ac[skb->priority];
}
if (!ieee80211_is_data_qos(hdr->frame_control)) {
skb->priority = 0;
return ieee802_1d_to_ac[skb->priority];
}

p = ieee80211_get_qos_ctl(hdr);
skb->priority = *p & IEEE80211_QOS_CTL_TAG1D_MASK;
Expand Down

0 comments on commit 861a57c

Please sign in to comment.