Skip to content

Commit

Permalink
[PATCH] paride: register_chrdev fix
Browse files Browse the repository at this point in the history
If the user specified `major=0' (odd thing to do), pg.c will use dynamic
allocation.  We need to pick up that major for subsequent unregister_chrdev().

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andrew Morton authored and Linus Torvalds committed Mar 28, 2006
1 parent a687fb1 commit 8637980
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/block/paride/pg.c
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,8 @@ static ssize_t pg_read(struct file *filp, char __user *buf, size_t count, loff_t

static int __init pg_init(void)
{
int unit, err = 0;
int unit;
int err;

if (disable){
err = -1;
Expand All @@ -657,16 +658,17 @@ static int __init pg_init(void)
goto out;
}

if (register_chrdev(major, name, &pg_fops)) {
err = register_chrdev(major, name, &pg_fops);
if (err < 0) {
printk("pg_init: unable to get major number %d\n", major);
for (unit = 0; unit < PG_UNITS; unit++) {
struct pg *dev = &devices[unit];
if (dev->present)
pi_release(dev->pi);
}
err = -1;
goto out;
}
major = err; /* In case the user specified `major=0' (dynamic) */
pg_class = class_create(THIS_MODULE, "pg");
if (IS_ERR(pg_class)) {
err = PTR_ERR(pg_class);
Expand Down

0 comments on commit 8637980

Please sign in to comment.