Skip to content

Commit

Permalink
ALSA: asihpi - Correct headers in cached control responses.
Browse files Browse the repository at this point in the history
Previously, only payload and size were correct, sufficient for reading,
but other fields produced spurious debug output.

Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Eliot Blennerhassett authored and Takashi Iwai committed Dec 22, 2011
1 parent f50efa2 commit 8637bc9
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion sound/pci/asihpi/hpicmn.c
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,8 @@ short hpi_check_control_cache(struct hpi_control_cache *p_cache,
}

phr->error = 0;
phr->specific_error = 0;
phr->version = 0;

/* set the default response size */
response_size =
Expand Down Expand Up @@ -531,8 +533,12 @@ short hpi_check_control_cache(struct hpi_control_cache *p_cache,
found ? "Cached" : "Uncached", phm->adapter_index,
pI->control_index, pI->control_type, phm->u.c.attribute);

if (found)
if (found) {
phr->size = (u16)response_size;
phr->type = HPI_TYPE_RESPONSE;
phr->object = phm->object;
phr->function = phm->function;
}

return found;
}
Expand Down

0 comments on commit 8637bc9

Please sign in to comment.