Skip to content

Commit

Permalink
new helper: daemonize_descriptors()
Browse files Browse the repository at this point in the history
descriptor-related parts of daemonize, done right.  As the
result we simplify the locking rules for ->files - we
hold task_lock in *all* cases when we modify ->files.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Sep 27, 2012
1 parent 2be7fd5 commit 864bdb3
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
6 changes: 6 additions & 0 deletions fs/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,12 @@ struct files_struct init_files = {
.file_lock = __SPIN_LOCK_UNLOCKED(init_task.file_lock),
};

void daemonize_descriptors(void)
{
atomic_inc(&init_files.count);
reset_files_struct(&init_files);
}

/*
* allocate a file descriptor, mark it busy.
*/
Expand Down
1 change: 1 addition & 0 deletions include/linux/fdtable.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ struct task_struct;
struct files_struct *get_files_struct(struct task_struct *);
void put_files_struct(struct files_struct *fs);
void reset_files_struct(struct files_struct *);
void daemonize_descriptors(void);
int unshare_files(struct files_struct **);
struct files_struct *dup_fd(struct files_struct *, int *);
void do_close_on_exec(struct files_struct *);
Expand Down
4 changes: 1 addition & 3 deletions kernel/exit.c
Original file line number Diff line number Diff line change
Expand Up @@ -457,9 +457,7 @@ void daemonize(const char *name, ...)
/* Become as one with the init task */

daemonize_fs_struct();
exit_files(current);
current->files = init_task.files;
atomic_inc(&current->files->count);
daemonize_descriptors();

reparent_to_kthreadd();
}
Expand Down

0 comments on commit 864bdb3

Please sign in to comment.