Skip to content

Commit

Permalink
[PATCH] drm: Fix issue reported by Coverity in drivers/char/drm/via_i…
Browse files Browse the repository at this point in the history
…rq.c

This patch tries to fix an issue reported in drivers/char/drm/via_irq.c by
Coverity, please review and apply if correct.

Error reported:
CID: 3444 Checker: REVERSE_INULL (help)
File: /export2/p4-coverity/mc2/linux26/drivers/char/drm/via_irq.c
Function: via_driver_irq_wait
Description: Pointer "dev_priv" dereferenced before NULL check

Patch Description:
 Move de-referencing dev_priv to after the NULL check.

Signed-off-by: Jayachandran C. <c.jayachandran at gmail.com>
Signed-off-by: Dave Airlie <airlied@linux.ie>
  • Loading branch information
Dave Airlie committed Apr 5, 2006
1 parent 6246b61 commit 86678df
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/char/drm/via_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ via_driver_irq_wait(drm_device_t * dev, unsigned int irq, int force_sequence,
unsigned int cur_irq_sequence;
drm_via_irq_t *cur_irq = dev_priv->via_irqs;
int ret = 0;
maskarray_t *masks = dev_priv->irq_masks;
maskarray_t *masks;
int real_irq;

DRM_DEBUG("%s\n", __FUNCTION__);
Expand All @@ -221,7 +221,8 @@ via_driver_irq_wait(drm_device_t * dev, unsigned int irq, int force_sequence,
__FUNCTION__, irq);
return DRM_ERR(EINVAL);
}


masks = dev_priv->irq_masks;
cur_irq += real_irq;

if (masks[real_irq][2] && !force_sequence) {
Expand Down

0 comments on commit 86678df

Please sign in to comment.