Skip to content

Commit

Permalink
igb: remove disable_av variable from mac_info struct
Browse files Browse the repository at this point in the history
The disable_av variable is never used by the driver and provides no value as
it is likely a leftover debugging variable.  I have removed it and replaced
the one spot that checked for it with a check for a valid address.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Duyck authored and David S. Miller committed Feb 7, 2009
1 parent fa4dfae commit 8675737
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion drivers/net/igb/e1000_hw.h
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,6 @@ struct e1000_mac_info {
bool asf_firmware_present;
bool autoneg;
bool autoneg_failed;
bool disable_av;
bool disable_hw_init_bits;
bool get_link_status;
bool ifs_params_forced;
Expand Down
3 changes: 2 additions & 1 deletion drivers/net/igb/e1000_mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,8 @@ void igb_rar_set(struct e1000_hw *hw, u8 *addr, u32 index)

rar_high = ((u32) addr[4] | ((u32) addr[5] << 8));

if (!hw->mac.disable_av)
/* If MAC address zero, no need to set the AV bit */
if (rar_low || rar_high)
rar_high |= E1000_RAH_AV;

wr32(E1000_RAL(index), rar_low);
Expand Down

0 comments on commit 8675737

Please sign in to comment.