Skip to content

Commit

Permalink
[media] r820t: split the function that read cached regs
Browse files Browse the repository at this point in the history
As we'll need to retrieve cached registers, make this
function explicit.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Tested-by: Antti Palosaari <crope@iki.fi>
  • Loading branch information
Mauro Carvalho Chehab committed Apr 17, 2013
1 parent 75c1819 commit 8678b03
Showing 1 changed file with 15 additions and 5 deletions.
20 changes: 15 additions & 5 deletions drivers/media/tuners/r820t.c
Original file line number Diff line number Diff line change
Expand Up @@ -402,15 +402,25 @@ static int r820t_write_reg(struct r820t_priv *priv, u8 reg, u8 val)
return r820t_write(priv, reg, &val, 1);
}

static int r820t_write_reg_mask(struct r820t_priv *priv, u8 reg, u8 val,
u8 bit_mask)
static int r820t_read_cache_reg(struct r820t_priv *priv, int reg)
{
int r = reg - REG_SHADOW_START;
reg -= REG_SHADOW_START;

if (r >= 0 && r < NUM_REGS)
val = (priv->regs[r] & ~bit_mask) | (val & bit_mask);
if (reg >= 0 && reg < NUM_REGS)
return priv->regs[reg];
else
return -EINVAL;
}

static int r820t_write_reg_mask(struct r820t_priv *priv, u8 reg, u8 val,
u8 bit_mask)
{
int rc = r820t_read_cache_reg(priv, reg);

if (rc < 0)
return rc;

val = (rc & ~bit_mask) | (val & bit_mask);

return r820t_write(priv, reg, &val, 1);
}
Expand Down

0 comments on commit 8678b03

Please sign in to comment.