Skip to content

Commit

Permalink
usb: phy: Find the right match in devm_usb_phy_match
Browse files Browse the repository at this point in the history
The res parameter passed to devm_usb_phy_match() is the location where the
pointer to the usb_phy is stored, hence it needs to be dereferenced before
comparing to the match data in order to find the correct match.

Fixes: 410219d ("usb: otg: utils: devres: Add API's to associate a device with the phy")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: <stable@vger.kernel.org> # v3.6+
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Axel Lin authored and Felipe Balbi committed Mar 19, 2015
1 parent 467a78c commit 869aee0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/usb/phy/phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ static void devm_usb_phy_release(struct device *dev, void *res)

static int devm_usb_phy_match(struct device *dev, void *res, void *match_data)
{
return res == match_data;
struct usb_phy **phy = res;

return *phy == match_data;
}

/**
Expand Down

0 comments on commit 869aee0

Please sign in to comment.