Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 5674
b: refs/heads/master
c: ba02508
h: refs/heads/master
v: v3
  • Loading branch information
Tejun Heo authored and Linus Torvalds committed Aug 5, 2005
1 parent ca6b51d commit 876471a
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 4 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: c7546f8f03f5a4fa612605b6be930234d6026860
refs/heads/master: ba02508248e90a9d696aebd18b48a3290235b53c
18 changes: 15 additions & 3 deletions trunk/drivers/block/ll_rw_blk.c
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ struct request *blk_queue_find_tag(request_queue_t *q, int tag)
{
struct blk_queue_tag *bqt = q->queue_tags;

if (unlikely(bqt == NULL || tag >= bqt->max_depth))
if (unlikely(bqt == NULL || tag >= bqt->real_max_depth))
return NULL;

return bqt->tag_index[tag];
Expand Down Expand Up @@ -798,6 +798,7 @@ init_tag_map(request_queue_t *q, struct blk_queue_tag *tags, int depth)

memset(tag_index, 0, depth * sizeof(struct request *));
memset(tag_map, 0, nr_ulongs * sizeof(unsigned long));
tags->real_max_depth = depth;
tags->max_depth = depth;
tags->tag_index = tag_index;
tags->tag_map = tag_map;
Expand Down Expand Up @@ -871,12 +872,23 @@ int blk_queue_resize_tags(request_queue_t *q, int new_depth)
if (!bqt)
return -ENXIO;

/*
* if we already have large enough real_max_depth. just
* adjust max_depth. *NOTE* as requests with tag value
* between new_depth and real_max_depth can be in-flight, tag
* map can not be shrunk blindly here.
*/
if (new_depth <= bqt->real_max_depth) {
bqt->max_depth = new_depth;
return 0;
}

/*
* save the old state info, so we can copy it back
*/
tag_index = bqt->tag_index;
tag_map = bqt->tag_map;
max_depth = bqt->max_depth;
max_depth = bqt->real_max_depth;

if (init_tag_map(q, bqt, new_depth))
return -ENOMEM;
Expand Down Expand Up @@ -913,7 +925,7 @@ void blk_queue_end_tag(request_queue_t *q, struct request *rq)

BUG_ON(tag == -1);

if (unlikely(tag >= bqt->max_depth))
if (unlikely(tag >= bqt->real_max_depth))
/*
* This can happen after tag depth has been reduced.
* FIXME: how about a warning or info message here?
Expand Down
1 change: 1 addition & 0 deletions trunk/include/linux/blkdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ struct blk_queue_tag {
struct list_head busy_list; /* fifo list of busy tags */
int busy; /* current depth */
int max_depth; /* what we will send to device */
int real_max_depth; /* what the array can hold */
atomic_t refcnt; /* map can be shared */
};

Expand Down

0 comments on commit 876471a

Please sign in to comment.