Skip to content

Commit

Permalink
sfc: Fix internal indices of ethtool stats for EF10
Browse files Browse the repository at this point in the history
The indices in nic_data->stats need to match the EF10_STAT_whatever
enum values.  In efx_nic_update_stats, only mask; gaps are removed in
efx_ef10_update_stats.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
  • Loading branch information
Edward Cree authored and Ben Hutchings committed Oct 4, 2013
1 parent d546a89 commit 87648cc
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/net/ethernet/sfc/nic.c
Original file line number Diff line number Diff line change
Expand Up @@ -469,8 +469,7 @@ size_t efx_nic_describe_stats(const struct efx_hw_stat_desc *desc, size_t count,
* @count: Length of the @desc array
* @mask: Bitmask of which elements of @desc are enabled
* @stats: Buffer to update with the converted statistics. The length
* of this array must be at least the number of set bits in the
* first @count bits of @mask.
* of this array must be at least @count.
* @dma_buf: DMA buffer containing hardware statistics
* @accumulate: If set, the converted values will be added rather than
* directly stored to the corresponding elements of @stats
Expand Down Expand Up @@ -503,11 +502,9 @@ void efx_nic_update_stats(const struct efx_hw_stat_desc *desc, size_t count,
}

if (accumulate)
*stats += val;
stats[index] += val;
else
*stats = val;
stats[index] = val;
}

++stats;
}
}

0 comments on commit 87648cc

Please sign in to comment.